emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: move_it_vertically_backward question


From: Po Lu
Subject: Re: move_it_vertically_backward question
Date: Thu, 23 Dec 2021 18:29:24 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

> Does the code DTRT in your use cases, and is it OK performance-wise to
> consider it stable enough for master?

Thanks, I fixed the other issues you pointed out, and yes, it works very
well.

> In principle, the offset could be a bignum or even a float, so the
> restriction here seems to be too stringent, no?  A float in particular
> could be useful, I think, in case the caller calculated the pixels as
> a float.

I don't think that's consistent with everywhere else we accept a pixel
value (for example, posn-at-x-y).

Thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]