emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum


From: Dmitry Gutov
Subject: Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
Date: Tue, 21 Dec 2021 19:19:22 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 21.12.2021 08:57, Eli Zaretskii wrote:
On December 21, 2021 6:08:25 AM GMT+02:00, Dmitry Gutov <dgutov@yandex.ru> 
wrote:
On 20.12.2021 18:17, Eli Zaretskii wrote:
From: Dmitry Gutov<dgutov@yandex.ru>
Date: Mon, 20 Dec 2021 03:07:08 +0300

Hi Eli,

On 09.12.2021 18:02, Eli Zaretskii wrote:
-;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
+;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
Could you explain that change?
See

    https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html

That doesn't seem like a good idea: other packages depend on it being
compatible with Emacs 26.

The change that broke that should be reverted instead.



I'm okay with doing that  provided that the patch to revert is simple and safe. 
 Please show the patch.

I think I will let Joao take point on that.

Note that the Package-Requires header in emacs-28 doesn't matter much. The problem will arise when that change is merged to master and then (sometime later) the Version header is also bumped in flymake.el.

From that POV your change in emacs-28 wasn't necessary either, but we can ignore that branch and fix it better on master (do the revert of the previous change).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]