emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line


From: Alan Mackenzie
Subject: Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language
Date: Sat, 21 Aug 2021 09:55:57 +0000

Hello, Basil.

On Fri, Aug 20, 2021 at 23:43:30 +0100, Basil L. Contovounesios wrote:
> Alan Mackenzie [2021-08-20 21:20 +0000] wrote:

[ .... ]

> > I've just committed a patch to master which I think fixes the problem.

> Thanks!  That indeed fixes the hang here.

> If it stops the hangs from happening on Hydra as well, then the relevant
> electric-tests will no longer need to be skipped there.

> I see only one minor issue with the patch: it introduces a use of the
> macro c-benign-error before its definition, which gives rise to a
> byte-compiler warning.  I would have moved the macro's definition
> myself, but I see the file is organised in a particular way, so I leave
> that to you.

Sorry about that.  I completely missed that warning message (which
perhaps ought to be an error, since it compiles a function call instead
of expanding the macro).

I've moved the macro to earlier on in the file.  No big deal.  I've
committed the change, and it should be OK now.

> Thanks,

Thank you!

> -- 
> Basil

-- 
Alan Mackenzie (Nuremberg, Germany).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]