Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window

[Robert Pluim]

>>>>> On Thu, 24 Jun 2021 15:32:37 +0100, Alan Third <alan@idiocy.org> said:

    Alan> On Thu, Jun 24, 2021 at 04:15:25PM +0200, Robert Pluim wrote:
    >> >>>>> On Thu, 24 Jun 2021 15:07:33 +0100, Alan Third <alan@idiocy.org> 
said:
    >> 
    Alan> On Thu, Jun 24, 2021 at 03:05:43PM +0100, Alan Third wrote:
    >> >> If you revert 99adf4b2af is the menu behaviour better, worse or the
    >> >> same?
    >> 
    Alan> Oops, sorry, 982ecc5aa9. I rebased my local copy onto master, so it
    Alan> doesn't match what you'll be using just now.
    >> 
    >> Yes. Better with that reverted.

    Alan> Actually, if it's not too much hassle could you check whether just
    Alan> commenting out the lines:

    Alan>   [outerpool release];
    Alan>   outerpool = [[NSAutoreleasePool alloc] init];

    Alan> in ns_select fixes the problem, or does the whole commit need
    Alan> reverted?

Commenting out just those lines is not enough.

    Alan> The real solution to this problem is, I think, the old threadify all
    Alan> the things, which is what some of the refactoring in this branch is
    Alan> intended to make easier.

The two great problems in computer science are naming, scope creep,
and off-by-one errors

Robert
--