emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cleaning up rcirc


From: Philip Kaludercic
Subject: Re: Cleaning up rcirc
Date: Fri, 04 Jun 2021 18:09:33 +0000

Andreas Schwab <schwab@linux-m68k.org> writes:

> On Jun 04 2021, Philip Kaludercic wrote:
>
>> @@ -846,6 +898,7 @@ rcirc-send-ctcp
>>    (let ((args (if args (concat " " args) "")))
>>      (rcirc-send-privmsg process target
>>                          (format "\C-a%s%s\C-a" request args))))
>> +  "Send TARGET a REQUEST via PROCESS."
>>  
>>  (defun rcirc-buffer-process (&optional buffer)
>>    "Return the process associated with channel BUFFER.
>
> That looks like a pasto.

Hmm, I wrote most of the code then tried to selectively separate out
each change into it's own commit. Must have added that docstring at the
wrong point...

Either way, I also noticed there were other issues with the code, that I
have since fixed. Would it be ok to push the changes as a feature
branch, so that I don't have to re-send all the patches again and again?

> Andreas.

-- 
        Philip K.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]