emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and,


From: João Távora
Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations
Date: Tue, 25 May 2021 09:39:15 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> - We're not in the business of preventing people from shooting
>   themselves in the foot, so I think it's fine to pass the whole list of
>   completion and receive a whole list of annotated completions, even if
>   that runs the risk of receiving a list in a different order or with
>   different elements: we can document the expected behavior and just not
>   worry about the sneaky guys.  Who knows: those sneaky guys may end up
>   finding an actually good use for it.

Extremely unlikely.  More likely the sneak would work fine for one
frontend, but break another one.

I don't have extremely strong views here either, but as an API user, I
distrust endpoints that allow silly stuff and then warn "don't!
undefined consequences" in the docs.  It's much friendlier if there is
one less way to mess up, especially when developing.

> - For performance reasons it should be OK to call the "affixotation"
>   function one element (or a small number of elements) at a time, so we
>   only do it for those completions which are actually displayed.
>   So this function should not presume that it always receives the complete
>   lists of completions.  But here again, this seems to be a small matter
>   of documentation.

If it's OK to call it one at a time, the zorglubization function should
take one completion at a time, no transcendental presumption needed.

João



reply via email to

[Prev in Thread] Current Thread [Next in Thread]