emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and,


From: João Távora
Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations
Date: Mon, 24 May 2021 20:13:41 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

João Távora <joaotavora@gmail.com> writes:

> Daniel Mendler <mail@daniel-mendler.de> writes:
>
>> On 5/23/21 11:54 PM, João Távora wrote:
>
>> But regarding merging or not merging the patch, I don't agree with your
>> argument of taking this as leverage which makes the discussion more or
>> less difficult.
>
> I'm not taking this as "leverage", I just don't think icomplete.el
> should embark into what I consider (and apparently others) a misdesigned
> API.  We should strive to come up with maintainable and reliable
> systems, not just merge something because it happens to work and look
> nice (which is plain to see that it does).

By the way, another reason not to merge your patch as it is originally
is that it seems to affixate too many prospects, way way more than are
shown.  My alternative patch should, in principle, only annotate the
candidates that are to be displayed.  It also does suffix alignment (but
not prefix yet).  So my view is that there are edges to polish in
multiple angles and we shouldn't rush this.

João



reply via email to

[Prev in Thread] Current Thread [Next in Thread]