emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?


From: Eli Zaretskii
Subject: Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?
Date: Mon, 24 May 2021 17:27:35 +0300

> From: Sergey Organov <sorganov@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,
>     Stefan Monnier <monnier@iro.umontreal.ca>,
>     Clément Pit-Claudel <cpitclaudel@gmail.com> 
> Date: Mon, 24 May 2021 16:41:07 +0300
> 
> diff --git a/lisp/desktop.el b/lisp/desktop.el
> index fb7c6c79a1..20d9e0f268 100644
> --- a/lisp/desktop.el
> +++ b/lisp/desktop.el
> @@ -706,7 +706,8 @@ if different)."
>                                   "\\)\\'")))
>      (dolist (buffer (buffer-list))
>        (let ((bufname (buffer-name buffer)))
> -     (unless (or (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers
> +     (unless (or (nill bufname)
> +                 (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers
>                   (string-match-p preserve-regexp bufname))
>         (kill-buffer buffer)))))
>    (delete-other-windows)

AFAICT, kill-buffer already is a no-op when the buffer is dead.  So
what exactly does this fix?  (Apologies if I'm missing something: I
cannot say that I've read all the discussions in this thread to the
last detail.)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]