emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default


From: Bastien
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Wed, 19 May 2021 13:59:04 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Tue, 18 May 2021 16:28:44 +0200
>> Cc: Karl Fogel <kfogel@red-bean.com>, "Paul W. Rankin" <pwr@bydasein.com>,
>>  "Paul W. Rankin via Emacs development discussions." <emacs-devel@gnu.org>
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > Please don't make this change until you hear from Lars, who examined
>> > the original patch and decided to install it.  It doesn't get more
>> > "considerate" than that.
>> 
>> It does seem to be an unexpectedly (to me, at least) controversial
>> change, so perhaps it should be tweaked.  For instance, using fringe
>> markers (on frames that support that) instead of highlighting the entire
>> line, or something else that isn't that stark.
>
> I guess so, yes.

FWIW I'd prefer a fringe marker than the current fontification.

One problem I've seen while testing this feature for the last weeks is
that editing text within the fontified region will (expectedly) expand
the fontified part, questioning the very idea of having an "area" for
indicating where the bookmark points.

A fringe marker for the line where this point is seems useful enough.

2 cents,

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]