emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default


From: Karl Fogel
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Tue, 18 May 2021 01:58:37 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

On 18 May 2021, Paul W. Rankin" via "Emacs development discussions. wrote:
Ugh. Not sure how this slipped into master but it is not a
good/considerate idea to set default value of bookmark-fontify to t.

If there are no reasonable objections I'll push this later today.

I don't have a strong opinion either way, but if you're curious as to where this came from, it was here:

 commit ab6cb65cb2b6d11a7b690dfcea8d98611290fad9
 Author:     Boruch Baum <boruch_baum@gmx.com>
 AuthorDate: Tue May 4 10:58:52 2021 +0200
 Commit:     Lars Ingebrigtsen <larsi@gnus.org>
 CommitDate: Tue May 4 10:58:52 2021 +0200
Fontify lines when setting a bookmark * lisp/bookmark.el (bookmark-fontify): New user option (bug#48179).
     (bookmark-face): New face.
     (bookmark--fontify, bookmark--unfontify): New functions.
(bookmark-set-internal, bookmark--jump-via, bookmark-delete): Use
     them.

The discussion in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179 is quite long, so it might be worth reading before reverting.

Best regards,
-Karl



reply via email to

[Prev in Thread] Current Thread [Next in Thread]