[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA?] Controlling Isearch from the minibuffer
From: |
Juri Linkov |
Subject: |
Re: [ELPA?] Controlling Isearch from the minibuffer |
Date: |
Fri, 14 May 2021 21:20:09 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
>>>> Setting `isearch-message-function' is of no help, because there are some
>>>> tests for `(null isearch-message-function)' as well as some explicit
>>>> calls to `(isearch-message)' in isearch.el. As far as I can see, there
>>>> is no alternative to modifying the function `isearch-message' itself.
>>>
>>> Tests for `(null isearch-message-function)' were added as a temporary
>>> workaround until lazy count will be implemented in the minibuffer.
>>> We need to remove these workarounds anyway. So using
>>> isearch-message-function
>>> should be the right thing to do.
>>
>> Okay, that' a low hanging fruit then.
>
> I've attached a patch. I can't see any deleterious effect for the
> minibuffer and comint, which are the two places that set
> `isearch-message-function' in Emacs.
Do you see the correct lazy-count values in the minibuffer and comint
after removing `(null isearch-message-function)'?
> - (funcall (or isearch-message-function #'isearch-message)))
> + (isearch-message))
What do you think about adding `isearch-message' as the default value
of isearch-message-function? E.g.
#+begin_src diff
-(defvar isearch-message-function nil
+(defvar isearch-message-function #'isearch-message
#+end_src
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, (continued)
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/10
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/10
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/12
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/12
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/12
- Re: [WIP PATCH] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/13
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/13
- Re: [ELPA?] Controlling Isearch from the minibuffer, Jean Louis, 2021/05/13
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/14
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/14
- Re: [ELPA?] Controlling Isearch from the minibuffer,
Juri Linkov <=
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/16
- Re: [ELPA?] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/16
- Re: [ELPA?] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/25
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/29
- Re: [ELPA?] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/14
- Re: [ELPA?] Controlling Isearch from the minibuffer, Juri Linkov, 2021/05/16
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/16
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/21
- Re: [ELPA?] Controlling Isearch from the minibuffer, Eli Zaretskii, 2021/05/21
- Re: [ELPA?] Controlling Isearch from the minibuffer, Augusto Stoffel, 2021/05/21