Re: Proposing changes to adjust_frame_size

[martin rudalics]

> Here it is.  What I did:
>
>    1. emacs -Q ;; frame with menubar but no toolbar
>    2. switch to the emacs frame, the toolbar appeared
>    3. evaluate (frame--size-history) in *scratch*

Thank you.

> Frame size history of #<frame *scratch* - GNU Emacs at thinkpad-t440p 
0x5630772204d8>
> x_create_frame_1 (5), TS=80x25~>640x525, NS=80x25~>656x525, 
IS=80x25~>656x525, MS=16x42 IH IV
> gui_figure_window_size (5), TS=640x525~>640x756, TC=80x25~>80x36, 
NS=656x525~>656x756, IS=656x525~>656x756, MS=16x42 IH IV
> scroll-bar-width (3), NS=656x756~>672x756, IS=656x756~>672x756, MS=80x105
> scroll-bar-height (3), MS=80x105
> menu-bar-lines (2), MS=80x105
> x_create_frame_2 (0), MS=80x105
> xg_frame_set_char_size, invisible, PS=672x756, XS=672x756, DS=672x756
> xg_frame_set_char_size (5), MS=16x42 IH IV
> MapNotify, not hidden & not iconified, PS=672x756, DS=672x756
> xg_frame_set_char_size, visible, PS=672x756, XS=672x756, DS=672x756

This is the only xg_frame_set_char_size added by my change and it
shouldn't cause any difference.

> ConfigureNotify, PS=672x756, XS=672x756, DS=672x756
> xg_frame_resized, unchanged, PS=672x756, XS=672x756
> ConfigureNotify, PS=672x756, XS=789x845, DS=672x756

But thhis last ConfigureNotify event is not explicable to me, values
like 789x845 are unprecedented so far.  Does your WM deliberately resize
the frame?

> xg_frame_resized, changed, PS=672x756, XS=789x845
> change_frame_size_1, delayed, PS=672x756, XS=789x845, DS=672x756
> change_frame_size (5), TS=640x756~>757x845, TC=80x36~>94x40, 
NS=672x756~>789x845, IS=672x756~>789x845, MS=16x42 IH IV
> tool-bar-lines (2), MS=80x105 IH IV
> ConfigureNotify, PS=789x845, XS=789x804
> xg_frame_resized, changed, PS=789x845, XS=789x804

Here the native height shrinks from 845 to 804 which should be the tool
bar, now incorporated.

> change_frame_size_1, delayed, PS=789x845, XS=789x804
> change_frame_size (5), TS=757x845~>757x804, TC=94x40~>94x38, 
NS=789x845~>789x804, IS=789x845~>789x804, MS=16x42 IH IV

Can you please do the same but with the two instances that cause the bad
behavior removed?

And can you try to run a build with the bad behavior and a "floating"
frame?

martin