Re: News from the lexical world

[Stefan Monnier]

> But I guess this is a more generic problem? Any function added to
> sc-attribs-postselect-hook will need access to 'attribution and/or
> 'citation which are not in scope.

Indeed, I see now that it's documented in the docstring of
`sc-select-attribution`.

I installed the patch below which should fix it.  Please confirm.


        Stefan


diff --git a/lisp/mail/supercite.el b/lisp/mail/supercite.el
index dc1c641052b..d545b0c3f15 100644
--- a/lisp/mail/supercite.el
+++ b/lisp/mail/supercite.el
@@ -1128,6 +1128,8 @@ sc-select-attribution
 auto-selected citation string and the variable `attribution' is bound
 to the auto-selected attribution string."
   (run-hooks 'sc-attribs-preselect-hook)
+  (with-suppressed-warnings ((lexical citation attribution))
+    (defvar citation) (defvar attribution))
   (let ((query-p sc-confirm-always-p)
        attribution citation
        (attriblist sc-preferred-attribution-list))