Re: [PATCH] `completion-all-sorted-completions`: Add support for completion boundaries

[Daniel Mendler]

On 4/25/21 12:19 AM, Stefan Monnier wrote:
> > lisp/minibuffer.el (completion-all-sorted-completions): The history is
> > preprocessed by the function `minibuffer--sort-preprocess-history`.
> > The default value is prepended to the history.  The completion base
> > prefix string is removed from the history elements.  This allows
> > sorting by history position for completion tables which use completion
> > boundaries, in particular the file completion table.
> > test/lisp/minibuffer-tests.el (completion-all-sorted-completions): Add
> > tests for various combinations of with/without history/base/default.
>
> I massaged this to use the active voice and stick a bit closer to
> our conventions.

Thanks, I am sorry that you had to do the commit message massage again. 
I will write a better message next time.

> I massaged this so that `def` is also filtered through `base`
> (and also so that comments are properly punctuated).

Right, it is correct to remove the base from the default.

> And I changed this completion table to a list of strings, since lists of
> symbols happen to work most of the time but aren't officially supported
> (we support alists whose keys are symbols, OTOH).

Okay, good to know. But if symbol-keyed alists are supported, it makes 
sense to officially allow lists of symbols too? I've never seen breakage 
with symbol lists with various completion systems. I think I am using 
them somewhere.

Daniel