Re: master 5183123: Add Tramp recompilation

[Michael Albinus]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

Hi Basil,

> It looks like package--user-installed-p isn't currently designed to be
> used in this way:
>
> 0. emacs -Q
> 1. (progn
>      (require 'package)
>      (require 'tramp)
>      (setq read-extended-command-predicate
>            #'command-completion-default-include-p)
>      (read-extended-command))
> 2. C-j C-i
>
> Debugger entered--Lisp error: (wrong-type-argument package-desc nil)
>   signal(wrong-type-argument (package-desc nil))
>   package--user-installed-p(tramp)
>   tramp-recompile-elpa-command-completion-p(tramp-recompile-elpa
>                                             #<buffer *scratch*>)
>   command-completion-default-include-p(tramp-recompile-elpa
>                                        #<buffer *scratch*>)
>
> Should package--user-installed-p simply guard against a nil package
> descriptor?

That would be fine. But since Tramp must be backward compatible, I have
added a check in tramp-recompile-elpa-command-completion-p.

> Thanks,

Best regards, Michael.