[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch upstream Git for Elisp diff hunk headings
From: |
Basil L. Contovounesios |
Subject: |
Re: Patch upstream Git for Elisp diff hunk headings |
Date: |
Fri, 12 Feb 2021 17:39:41 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Kangas <stefankangas@gmail.com> writes:
> Adam Spiers <emacs-devel@adamspiers.org> writes:
>
>> While of course no one is claiming that this is technically correct in
>> all cases, I don't think I can actually recall ever seeing a single
>> instance of a top-level form which *was* indented. So presumably it's
>> a good enough heuristic to be helpful in the vast majority of cases.
>> Or at least it's more likely to be right than a heuristic which
>> assumes that all top-level forms include "def" in the first symbol in
>> the form, since the latter obviously fails in many common scenarios
>> including the init files one mentioned above.
>
> (It also fails with `ert-deftest', and probably also other unit test
> frameworks in popular use.)
The current regexp doesn't fail on ert-deftest.
--
Basil