[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch upstream Git for Elisp diff hunk headings
From: |
Stefan Kangas |
Subject: |
Re: Patch upstream Git for Elisp diff hunk headings |
Date: |
Thu, 11 Feb 2021 13:05:19 -0600 |
Adam Spiers <emacs-devel@adamspiers.org> writes:
> While of course no one is claiming that this is technically correct in
> all cases, I don't think I can actually recall ever seeing a single
> instance of a top-level form which *was* indented. So presumably it's
> a good enough heuristic to be helpful in the vast majority of cases.
> Or at least it's more likely to be right than a heuristic which
> assumes that all top-level forms include "def" in the first symbol in
> the form, since the latter obviously fails in many common scenarios
> including the init files one mentioned above.
(It also fails with `ert-deftest', and probably also other unit test
frameworks in popular use.)
I'd say go for it. The heuristics seems like a clear improvement and
this feature would be appreciated.
Thanks for working on this.