Re: master 9f464cc: Stop using calc for ntlm time computation

[Thomas Fitzsimmons]

Mattias Engdegård <mattiase@acm.org> writes:

> 27 okt. 2020 kl. 14.06 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>
>>> I've pushed a new implementation. Perhaps someone with a 32-bit Emacs < 27.1
>>> would try it out. Running the test would suffice.
>> 
>>    lisp/net/ntlm-tests.el:53:1:Warning: the function 
>> ‘ntlm--time-to-timestamp’ is
>>        not known to be defined.
>
> Sorry, I should have been more specific. You need to run an old (32-bit) 
> Emacs but with ntlm from trunk, as if using the ELPA package.
> Not quite sure how that is accomplished in practice but you figure it out.

On older Emacs versions you'll need the attached too, which I haven't
pushed yet.

Thomas

diff --git a/lisp/net/ntlm.el b/lisp/net/ntlm.el
index 9401430799..1de9291017 100644
--- a/lisp/net/ntlm.el
+++ b/lisp/net/ntlm.el
@@ -152,7 +152,9 @@ ntlm--time-to-timestamp
 
 (defun ntlm-compute-timestamp ()
   "Current time as an NTLMv2 timestamp, as a unibyte string."
-  (ntlm--time-to-timestamp (time-convert nil 'list)))
+  (ntlm--time-to-timestamp (if (functionp 'time-convert)
+                               (time-convert nil 'list)
+                             (append (current-time) '(0 0)))))
 
 (defun ntlm-generate-nonce ()
   "Generate a random nonce, not to be used more than once.