Re: master 9f464cc: Stop using calc for ntlm time computation

[Stefan Monnier]

> Didn't get there yet.  Here's my latest attempt:

OK, I found another problem in the way I was running the tests, so
I think I finally did manage to run them correctly, which indeed finds
a real problem:

    % make EMACS="/usr/bin/emacs" EMACS_EXTRAOPT="-l 
/u/monnier/src/emacs/trunk/lisp/net/ntlm.el" MODULES_EMACSOPT="" 
test/lisp/net/ntlm-tests
    make -C test lisp/net/ntlm-tests
    make[1] : on entre dans le répertoire « /home/monnier/src/emacs/trunk/test »
    make[2] : on entre dans le répertoire « /home/monnier/src/emacs/trunk/test »
      GEN      lisp/net/ntlm-tests.log
    Running 1 tests (2020-10-27 09:42:55-0400)
    Test ntlm-time-to-timestamp backtrace:
      signal(wrong-type-argument (integerp 1.1644473632001902e+17))
      apply(signal (wrong-type-argument (integerp 1.1644473632001902e+17))
      (setq value-2 (apply fn-0 args-1))
      (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri
      (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
      (let (form-description-4) (if (unwind-protect (setq value-2 (apply f
      (let ((value-2 (quote ert-form-evaluation-aborted-3))) (let (form-de
      (let* ((fn-0 (function equal)) (args-1 (condition-case err (let ((si
      (let ((time (quote (24471 63910 412962 0)))) (let* ((fn-0 (function 
      (closure (t) nil (let ((time (quote (24471 63910 412962 0)))) (let* 
      ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
      ert-run-test(#s(ert-test :name ntlm-time-to-timestamp :documentation
      ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) 
      ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
      ert-run-tests-batch((not (tag :unstable)))
      ert-run-tests-batch-and-exit((not (tag :unstable)))
      eval((ert-run-tests-batch-and-exit (quote (not (tag :unstable)))))
      command-line-1(("-L" ":." "-l" "/u/monnier/src/emacs/trunk/lisp/net/
      command-line()
      normal-top-level()
    Test ntlm-time-to-timestamp condition:
        (wrong-type-argument integerp 1.1644473632001902e+17)
       FAILED  1/1  ntlm-time-to-timestamp
    
    Ran 1 tests, 0 results as expected, 1 unexpected (2020-10-27 09:42:55-0400)
    
    1 unexpected results:
       FAILED  ntlm-time-to-timestamp

The problem is that in `ntlm-tests--time-to-timestamp`, the constant
116444736000000000 is too large.


        Stefan