Re: master f0b0105: Hoist some byte-code checking out of eval

[Stefan Monnier]

> Oh, now that you mention it I do see something missing: Fbyte_code converts
> bytestr to unibyte whereas Fmake_byte_code merely checks that bytestr is
> unibyte, and I suppose it should be consistent with Fbyte_code here. I'll
> look into fixing that. This should matter only when dealing with Emacs
> 20.2-and-older bytecode strings (do we still need to worry about that?).
>
> You wrote "*some* .. but not all", which vaguely implies that I was missing
> more than one check. Am I missing something else here?

I just saw that the checks were not textually the same (I expected
basically "exactly" the same code to be duplicated to `Fbyte_code` and
`make-byte-code`; not sure if `Ffetch_bytecode` also needs some of that
treatment).


        Stefan