emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again


From: Basil L. Contovounesios
Subject: Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again
Date: Thu, 07 May 2020 21:21:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> diff --git a/lisp/dnd.el b/lisp/dnd.el
>> index c185794..102bc75 100644
>> --- a/lisp/dnd.el
>> +++ b/lisp/dnd.el
>> @@ -101,6 +101,8 @@ is what has been dropped.  Returns ACTION."
>>         (throw 'done t)))
>>         nil)
>>       (catch 'done
>> +       ;; Autoloaded but the byte-compiler still complains.
>> +       (declare-function browse-url-select-handler "browse-url" (url))
>>         (let ((browser (browse-url-select-handler url)))
>>           (when browser
>>             (setq ret 'private)
>
> It complains because the ;;;###autoload cookie had not yet been turned
> into an actual autoload in `lisp/loaddefs.el`.
> IOW what was missing was `cd lisp; make autoloads`.

That was my first thought as well, but 'make bootstrap' was still
complaining after verifying

  $ grep browse-url-select-handler lisp/loaddefs.el
  (autoload 'browse-url-select-handler "browse-url" "\

so I assumed the warning was due to bootstrapping order and added the
declaration anyway.

> I also get caught by those things every once in a while.
> It would be good to find a way to automatically guess when to run `make 
> autoloads`.

Is it run in time as part of 'make bootstrap'?

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]