|
| From: | Eric Abrahamsen |
| Subject: | Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's |
| Date: | Fri, 01 May 2020 17:03:26 -0700 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Monnier <address@hidden> writes: >> Inhibit modification hooks when saving eieio-persistent's >> >> * lisp/emacs-lisp/eieio-base.el (eieio-persistent-save): Bind >> inhibit-modification-hooks -> t. > > I think this deserves an explanation (as a extensive comment explaining > why it's needed and why we think it's safe to do it here.) > > Binding `inhibit-modification-hooks` is not as dangerous as binding > `inhibit-quit` but it's something we should still avoid as much > as possible. I'm curious what the objection is -- why would we *want* modification hooks to run when writing an eieio object out to file?
| [Prev in Thread] | Current Thread | [Next in Thread] |