emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New warning in indent.c


From: Paul Eggert
Subject: Re: New warning in indent.c
Date: Thu, 16 Apr 2020 09:27:01 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 4/16/20 3:09 AM, Eli Zaretskii wrote:

I guess the "change" which triggered this was a newer GCC version.

Yes, most likely. However, the warning was a symptom of an underlying problem: the code wasn't checking the type of 'lcols' early enough. I fixed the underlying problem via the attached patch, and this should remove the need for pacifying GCC. In some sense I suppose we should be grateful for GCC's silly warning here, as it pointed out the awkward code.

Attachment: 0001-Fix-type-checking-bug-in-vertical-motion.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]