[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs 27 face :extend attribute not working with pulse.el?
From: |
Eli Zaretskii |
Subject: |
Re: Emacs 27 face :extend attribute not working with pulse.el? |
Date: |
Thu, 09 Apr 2020 19:46:26 +0300 |
> From: Adam Porter <address@hidden>
> Date: Thu, 09 Apr 2020 09:46:40 -0500
>
> >> This seems like an obvious, easy fix to restore the previous behavior,
> >> but I don't know if it's the "correct" one, because it appears to have
> >> the side effect of forcing extension even when
> >> pulse-momentary-highlight-one-line is called with a face argument which
> >> does not have ":extend t" set.
> >
> > Does the patch below produce good results?
> >
> > diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
> > index 16243e1..8649254 100644
> > --- a/lisp/cedet/pulse.el
> > +++ b/lisp/cedet/pulse.el
> > @@ -161,6 +161,9 @@ pulse-reset-face
> > (face-background face nil t)
> > (face-background 'pulse-highlight-start-face)
> > ))
> > + (and face
> > + (set-face-extend 'pulse-highlight-face
> > + (face-extend-p face nil t)))
> > (put 'pulse-highlight-face :startface (or face
> > 'pulse-highlight-start-face))
> > (put 'pulse-highlight-face :iteration 0))
>
> Yes, it seems to behave as expected. Thanks.
Thanks, installed on the emacs-27 branch.