[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fill column indicator functionality
From: |
Basil L. Contovounesios |
Subject: |
Re: Fill column indicator functionality |
Date: |
Fri, 03 May 2019 16:25:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>> From: "Basil L. Contovounesios" <address@hidden>
>> Cc: Ergus <address@hidden>, <address@hidden>
>> Date: Fri, 03 May 2019 15:14:50 +0100
>>
>> >> +;; Definition stolen from display-line-numbers.
>> >> +(defface fill-column-face
>> >> + '((t :inherit (shadow default)))
>> >> + "Face for displaying fill column indicator line.
>> > ^^^^
>> > I'd drop the "line" part. You allude to the shape of the indicator
>> > character, but it doesn't have to look like a line, and using "line"
>> > is confusing here.
>>
>> I'm not sure how closely this convention is followed in new code, but
>> FWIW the defface docs under (info "(elisp) Defining Faces") say:
>>
>> -- Macro: defface face spec doc [keyword value]...
>> This macro declares FACE as a named face whose default face spec is
>> given by SPEC. You should not quote the symbol FACE, and it should
>> not end in ‘-face’ (that would be redundant).
>> ^^^^^^^^^^^^^^^^^^
>
> If you drop the -face part in this case, you are left with
> fill-column, and we already have a variable by that name. So in this
> case following that rule would be detrimental, I'd say.
Well, it could also be called something else,
e.g. fill-column-indicator. But it's not important.
> Also, I think this name follows what fci-mode did.
FWIW, I don't think fci-mode defines any faces, just user options like
fci-rule-color, fci-rule-width, fci-rule-character-color, etc.
Thanks,
--
Basil
- Re: Fill column indicator functionality, Ergus, 2019/05/01
- Re: Fill column indicator functionality, Ergus, 2019/05/03
- Re: Fill column indicator functionality, Eli Zaretskii, 2019/05/03
- Re: Fill column indicator functionality, Eli Zaretskii, 2019/05/03
- Re: Fill column indicator functionality, Ergus, 2019/05/03
- Re: Fill column indicator functionality, Eli Zaretskii, 2019/05/04
- Re: Fill column indicator functionality, Ergus, 2019/05/04
- Re: Fill column indicator functionality, Eli Zaretskii, 2019/05/04
- Re: Fill column indicator functionality, Óscar Fuentes, 2019/05/04