Re: Questionable code in handling of wordend in the regexp engine in regex-emacs.c

[Eli Zaretskii]

> Date: Tue, 5 Mar 2019 10:51:50 +0000
> Cc: address@hidden, address@hidden
> From: Alan Mackenzie <address@hidden>
> 
> > I see 2 possible ways to handle this: (1) remove the assertion for
> > good, or (2) change buf_bytepos_to_charpos to accept one more
> > argument, telling it whether to make this check, and then modify all
> > the callers except those in set_intervals_multibyte_1 to pass 'true'
> > as that argument.
> 
> > Thoughts?
> 
> First of all, sorry I wasn't here yesterday to deal with it.

No sweat: since this popped up in my own build, it was very easy to
understand the reasons.

> I don't think I like alternative (2) - it's ugly, and how much do we
> really need this eassert anyway?  It's turned out not to be such a good
> idea after all.  I would favour alternative (1), just removing the thing
> altogether.

Agreed; done.

Thanks.