emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Questionable code in handling of wordend in the regexp engine in reg


From: Eli Zaretskii
Subject: Re: Questionable code in handling of wordend in the regexp engine in regex-emacs.c
Date: Fri, 01 Mar 2019 21:31:37 +0200

> Date: Fri, 1 Mar 2019 19:16:07 +0000
> Cc: address@hidden, address@hidden
> From: Alan Mackenzie <address@hidden>
> 
> +  /* Check bytepos is not in the middle of a character. */
> +  eassert (bytepos >= BUF_Z_BYTE (b)
> +           || CHAR_HEAD_P (BUF_FETCH_BYTE (b, bytepos)));

LGTM.

> After configuring with --enable-checking and building, I tried make
> check.  The tests errored out with this bytepos check three times.  In:
> 
>     src/coding-tests.log
>     lisp/epg-tests.log
>     lisp/emacs-lisp/package-tests.log
> 
> .  Quite possibly there is just one bug here, but there might be two or
> three.  I think it would be best to track it/them down before committing
> the change to marker.c.

I agree.  Let me know if you need help with that.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]