[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Thoughts on getting correct line numbers in the byte compiler's warn
From: |
Alan Mackenzie |
Subject: |
Re: Thoughts on getting correct line numbers in the byte compiler's warning messages |
Date: |
Mon, 12 Nov 2018 14:16:32 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hello, Eli.
On Sun, Nov 11, 2018 at 17:53:13 +0200, Eli Zaretskii wrote:
> > Date: Sun, 11 Nov 2018 12:59:45 +0000
> > From: Alan Mackenzie <address@hidden>
> > Cc: Michael Heerdegen <address@hidden>, address@hidden
> >
> > I've now got this working, and created the new, optimistically named,
> > branch /scratch/accurate-warning-pos.
> Thanks.
> +/* Return a new located symbol with the specified SYMBOL and LOCATION. */
> +Lisp_Object
> +build_located_symbol (Lisp_Object symbol, Lisp_Object location)
> +{
> I'd prefer something like symbol_with_pos instead, and accordingly in
> other related symbol names.
DONE.
> +DEFUN ("only-symbol-p", Fonly_symbol_p, Sonly_symbol_p, 1, 1, 0,
> + doc: /* Return t if OBJECT is a symbol, but not a located symbol.
> */
> + attributes: const)
> + (Lisp_Object object)
> symbol-bare-p?
DONE. (bare-symbol-p)
[ .... ]
> diff --git a/src/lisp.h b/src/lisp.h
> index eb67626..b4fc6f2 100644
> --- a/src/lisp.h
> +++ b/src/lisp.h
> @@ -323,6 +323,64 @@ typedef union Lisp_X *Lisp_Word;
> typedef EMACS_INT Lisp_Word;
> #endif
> +/* A Lisp_Object is a tagged pointer or integer. Ordinarily it is a
> + Lisp_Word. However, if CHECK_LISP_OBJECT_TYPE, it is a wrapper
> + around Lisp_Word, to help catch thinkos like 'Lisp_Object x = 0;'.
> +
> + LISP_INITIALLY (W) initializes a Lisp object with a tagged value
> + that is a Lisp_Word W. It can be used in a static initializer. */
> Looks like you moved a large chunk of lisp.h to a different place in
> the file. Any reasons for that?
I've now moved all but a few inline functions back again.
> +/* FIXME!!! 2018-11-09. Consider using lisp_h_PSEUDOVECTOR here. */
> What is this FIXME about?
It's gone, the issue having been resolved.
> This needs support in src/.gdbinit and documentation.
Not yet done.
> Thanks again for working in this.
--
Alan Mackenzie (Nuremberg, Germany).
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, (continued)
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/07
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/08
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/08
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/08
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Eli Zaretskii, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Eli Zaretskii, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Eli Zaretskii, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages,
Alan Mackenzie <=
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/14
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/15
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/15
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/16
Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Michael Heerdegen, 2018/11/07