[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Thoughts on getting correct line numbers in the byte compiler's warn
From: |
Eli Zaretskii |
Subject: |
Re: Thoughts on getting correct line numbers in the byte compiler's warning messages |
Date: |
Sun, 11 Nov 2018 17:53:13 +0200 |
> Date: Sun, 11 Nov 2018 12:59:45 +0000
> From: Alan Mackenzie <address@hidden>
> Cc: Michael Heerdegen <address@hidden>, address@hidden
>
> I've now got this working, and created the new, optimistically named,
> branch /scratch/accurate-warning-pos.
Thanks.
+/* Return a new located symbol with the specified SYMBOL and LOCATION. */
+Lisp_Object
+build_located_symbol (Lisp_Object symbol, Lisp_Object location)
+{
I'd prefer something like symbol_with_pos instead, and accordingly in
other related symbol names.
+DEFUN ("only-symbol-p", Fonly_symbol_p, Sonly_symbol_p, 1, 1, 0,
+ doc: /* Return t if OBJECT is a symbol, but not a located symbol. */
+ attributes: const)
+ (Lisp_Object object)
symbol-bare-p?
+ DEFVAR_LISP ("located-symbols-enabled", Vlocated_symbols_enabled,
+ doc: /* Non-nil when "located symbols" can be used in place
of symbols.
What is the rationale for this variable?
diff --git a/src/lisp.h b/src/lisp.h
index eb67626..b4fc6f2 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -323,6 +323,64 @@ typedef union Lisp_X *Lisp_Word;
typedef EMACS_INT Lisp_Word;
#endif
+/* A Lisp_Object is a tagged pointer or integer. Ordinarily it is a
+ Lisp_Word. However, if CHECK_LISP_OBJECT_TYPE, it is a wrapper
+ around Lisp_Word, to help catch thinkos like 'Lisp_Object x = 0;'.
+
+ LISP_INITIALLY (W) initializes a Lisp object with a tagged value
+ that is a Lisp_Word W. It can be used in a static initializer. */
Looks like you moved a large chunk of lisp.h to a different place in
the file. Any reasons for that?
+/* FIXME!!! 2018-11-09. Consider using lisp_h_PSEUDOVECTOR here. */
What is this FIXME about?
This needs support in src/.gdbinit and documentation.
Thanks again for working in this.
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, (continued)
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/07
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/07
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/07
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/07
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/08
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/08
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/08
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages,
Eli Zaretskii <=
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Eli Zaretskii, 2018/11/11
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Eli Zaretskii, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/12
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Stefan Monnier, 2018/11/14
- Re: Thoughts on getting correct line numbers in the byte compiler's warning messages, Alan Mackenzie, 2018/11/15