[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: syntax based indentation for SQL files (ELPA package proposal)
|
From: |
Stefan Monnier |
|
Subject: |
Re: syntax based indentation for SQL files (ELPA package proposal) |
|
Date: |
Tue, 02 Oct 2018 08:57:02 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> This patch looks like it has been applied in the wrong place. Emacs
> builtin code should not depend on an external package. Why did you add
> this change into emacs, rather than the package that defines
> sqind-minor-mode ?
It doesn't actually depend on sql-indent. It just makes use of it
when available. Given that sql-indent is in GNU ELPA, I think this is
perfectly acceptable (and I'm pretty sure we have other similar cases
already in emacs.git, some of which for packages that aren't even in
GNU ELPA).
Stefan