Re: syntax based indentation for SQL files (ELPA package proposal)

[Andy Moreton]

On Mon 01 Oct 2018, Michael Mauger wrote:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Sunday, September 16, 2018 5:30 PM, Stefan Monnier <address@hidden> wrote:
>
>> > (defun sql-is-indent-available ()
>>
>> >       "Check if sql-indent module is available."
>> >       (when (locate-library "sql-indent")
>> >         (require 'sql-indent)
>> >         (fboundp 'sqlind-minor-mode)))
>> >
>>
>> I'd recommend you just use (fboundp 'sqlind-minor-mode) since the ELPA
>> package (or any proper manual install) sets up an autoload for it.
>>
>> Stefan
>
> I have pushed a change to sql.el to enable sqind-minor-mode if it is 
> available.

This patch looks like it has been applied in the wrong place. Emacs
builtin code should not depend on an external package. Why did you add
this change into emacs, rather than the package that defines
sqind-minor-mode ?

    AndyM