|
| From: | Ken Brown |
| Subject: | Re: [Emacs-diffs] master f18af6c: Audit use of lsh and fix glitches |
| Date: | Wed, 22 Aug 2018 09:35:53 -0400 |
| User-agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 8/22/2018 8:36 AM, Pip Cet wrote:
On Tue, Aug 21, 2018 at 9:01 PM Paul Eggert <address@hidden> wrote:* lisp/vc/vc-hg.el (vc-hg-state-fast): When testing fixnum width, prefer (zerop (ash most-positive-fixnum -32)) to (zerop (lsh -1 32)) (Bug#32485#11).I think the previous code was correct: now we have bignums, we should no longer return 'unsupported on machines with 30/32-bit fixnums,
I think you're missing the point of that code. The function is vc-hg-state-fast. If it returns 'unsupported, that simply means that the slower function will be used.
Ken
| [Prev in Thread] | Current Thread | [Next in Thread] |