Re: New warnings on emacs-26 branch with gcc 8.2.0

[Andy Moreton]

On Fri 17 Aug 2018, Eli Zaretskii wrote:

>> From: Andy Moreton <address@hidden>
>> Date: Tue, 14 Aug 2018 13:59:08 +0100
>> 
>> The attached patch fixes the -Wcast-function-type warnings when building
>> on Windows MSYS2 64bit (GCC 8.2.0) with "-Og". Theere is one remaining
>> compiler warning:
>> 
>> C:/emacs/git/emacs/master/src/w32fns.c: In function 'Fw32_read_registry':
>> C:/emacs/git/emacs/master/src/w32fns.c:10142:21: warning: 'rootkey' may be 
>> used uninitialized in this function [-Wmaybe-uninitialized]
>>    Lisp_Object val = w32_read_registry (NILP (root)
>>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>             ? HKEY_CURRENT_USER
>>             ~~~~~~~~~~~~~~~~~~~
>>             : rootkey,
>>             ~~~~~~~~~~
>>             key, name);
>>             ~~~~~~~~~~
>
> Thanks, pushed to the master branch.  I just made the new function's
> name a bit shorter.

Thanks. The warning shown above can be fixed with this patch:

diff --git a/src/w32fns.c b/src/w32fns.c
index c32868fa69..0ad5575e6f 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10125,7 +10125,7 @@ to be converted to forward slashes by the caller.  */)
   CHECK_STRING (key);
   CHECK_STRING (name);
 
-  HKEY rootkey;
+  HKEY rootkey UNINIT;
   if (EQ (root, QHKCR))
     rootkey = HKEY_CLASSES_ROOT;
   else if (EQ (root, QHKCU))