[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pcase: Semantics of atom QPATS
From: |
Michael Heerdegen |
Subject: |
Re: pcase: Semantics of atom QPATS |
Date: |
Sat, 16 Jun 2018 09:32:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> > Ok. Is this patch ok for emacs-26?
>
> Changes in documentation and comments are always okay there, but I'm
> uneasy with changes that modify behavior. Why is it important to
> support non-integer numbers in Emacs 26.2?
It's not important, no I thought it would be harmless, but master is ok
for me.
> > - ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat)
> > + ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat)
>
> Any reasons to use numberp and not number-or-marker-p?
Is it likely that someone constructs a pcase pattern with a literal
marker in it? Note this is about the pattern, not about the matched
value.
Michael.
- pcase: Semantics of atom QPATS, Michael Heerdegen, 2018/06/09
- Re: pcase: Semantics of atom QPATS, Stefan Monnier, 2018/06/11
- RE: pcase: Semantics of atom QPATS, Drew Adams, 2018/06/11
- Re: pcase: Semantics of atom QPATS, Michael Heerdegen, 2018/06/11
- Re: pcase: Semantics of atom QPATS, Michael Heerdegen, 2018/06/12
- Re: pcase: Semantics of atom QPATS, Stefan Monnier, 2018/06/13
- Re: pcase: Semantics of atom QPATS, Michael Heerdegen, 2018/06/16
- Re: pcase: Semantics of atom QPATS, Eli Zaretskii, 2018/06/16
- Re: pcase: Semantics of atom QPATS,
Michael Heerdegen <=
- Re: pcase: Semantics of atom QPATS, Eli Zaretskii, 2018/06/16
- Re: pcase: Semantics of atom QPATS, Michael Heerdegen, 2018/06/17
- Re: pcase: Semantics of atom QPATS, Noam Postavsky, 2018/06/16
- Re: pcase: Semantics of atom QPATS, Stefan Monnier, 2018/06/16