emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pcase: Semantics of atom QPATS


From: Eli Zaretskii
Subject: Re: pcase: Semantics of atom QPATS
Date: Sat, 16 Jun 2018 09:57:57 +0300

> From: Michael Heerdegen <address@hidden>
> Date: Sat, 16 Jun 2018 06:03:16 +0200
> Cc: address@hidden
> 
> Stefan Monnier <address@hidden> writes:
> 
> > Sure.  Feel free to add support for floats while you're there.
> 
> Ok.  Is this patch ok for emacs-26?

Changes in documentation and comments are always okay there, but I'm
uneasy with changes that modify behavior.  Why is it important to
support non-integer numbers in Emacs 26.2?

> -   ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat)
> +   ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat)

Any reasons to use numberp and not number-or-marker-p?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]