I have attached a new patch which incorporates all of the requested changes. length= now accepts only integers, not markers or floats. The doc string has been updated and a manual entry written. I included all of the bytecode changes as well since there were no objections. Those changes have been improved to account for various edge cases.
-------- Original Message --------
Subject: Re: [PATCH] Add new lisp function length= with bytecode support
Local Time: February 28, 2017 4:24 AM
UTC Time: February 28, 2017 9:24 AM
From: address@hidden
To: Gdobbins <address@hidden>
address@hidden <address@hidden>
On Feb 26 2017, Gdobbins <address@hidden> wrote:
> --- a/src/fns.c
> +++ b/src/fns.c
> @@ -137,6 +137,109 @@ which is at least the number of distinct elements. */)
> return make_fixnum_or_float (len);
> }
>
> +DEFUN ("length=", Flength_eqlsign, Slength_eqlsign, 1, MANY, 0,
> + doc: /* Each element of SEQUENCES may be any type accepted by
The first line of the docstring should be a full sentence, and describe
the function's purpose. Also, don't refer to the function arguments as
an element of the &rest variable, that could be interpreted as if the
function takes a single list as argument.
Andreas.
--
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
0001-Add-new-lisp-function-length-with-bytecode-support.patch