[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Please add comments to isearch.el
From: |
Artur Malabarba |
Subject: |
Re: Please add comments to isearch.el |
Date: |
Sun, 13 Dec 2015 01:01:22 +0000 |
On 12 Dec 2015 11:27 pm, "Juri Linkov" <address@hidden> wrote:
> 1. Rename ‘lax’ to ‘lax-boundary’ to distinguish between lax at the word/symbol
> boundary and lax-whitespace to avoid confusion, so rename the
> arg ‘lax’ to ‘lax-boundary’ in all regexp-producing functions,
> isearch--lax-regexp-function-p to
> isearch--lax-boundary-regexp-function-p, etc.
+1
> 2. Try to find a better common naming scheme used for the
> regexp-producing functions word-search-regexp, isearch-symbol-regexp,
> character-fold-to-regexp.
I think the first two shouldn't even be in isearch.el. There's a ton of stuff in isearch.el that's just generally useful in searches (nothing specific to incremental search), and should be moved to some search.el file.
> 3. Use well established terminology that shortens the prefixes
> of character-related functions to just char- to use char-fold.
> ‘C-h f char TAB’ or ‘C-h v char TAB’ shows the standard
> Emacs naming convention.
>
> 4. Use the upper-case standard name “Unicode” in the documentation.
I don't see what these have to do with the readability of isearch el, but by all means, feel free to do these. 👍
- Re: Please add comments to isearch.el, (continued)
- Re: Please add comments to isearch.el, Artur Malabarba, 2015/12/11
- RE: Please add comments to isearch.el, Drew Adams, 2015/12/11
- Re: Please add comments to isearch.el, Eli Zaretskii, 2015/12/11
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/11
- Re: Please add comments to isearch.el, Artur Malabarba, 2015/12/11
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/11
- Re: Please add comments to isearch.el, Eli Zaretskii, 2015/12/12
- RE: Please add comments to isearch.el, Drew Adams, 2015/12/12
- Re: Please add comments to isearch.el, John Wiegley, 2015/12/12
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/12
- Re: Please add comments to isearch.el,
Artur Malabarba <=
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/13
- Re: Please add comments to isearch.el, Artur Malabarba, 2015/12/13
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/14
- Re: Please add comments to isearch.el, Artur Malabarba, 2015/12/15
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/15
- Re: Please add comments to isearch.el, Artur Malabarba, 2015/12/16
- Re: Please add comments to isearch.el, Juri Linkov, 2015/12/16
- Re: Please add comments to isearch.el, Artur Malabarba, 2015/12/17
- Re: Please add comments to isearch.el, Eli Zaretskii, 2015/12/12