[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ERT indentation testing
From: |
Ted Zlatanov |
Subject: |
Re: ERT indentation testing |
Date: |
Wed, 01 Jun 2011 16:30:56 -0500 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) |
On Thu, 19 May 2011 08:56:07 -0300 Stefan Monnier <address@hidden> wrote:
>>>> This can be done with ERT, right? A bunch of .cc files with file-local
>>>> variables could be indented "properly" for those variables. Then the
>>>> test logic for each file is
SM> [...]
>>>> Plus, of course, it's not limited to .cc files. It would work just as
>>>> well for .c, .pl, .el, whatever.
SM> Yup, we already have such files in test/indent.
>> Yes, I see that now (I didn't see the commit for those, cool!)
>> We should have .c and .cc files with the major indentation styles
>> specified as file-local variables, plus .ini, Perl, Java, Python, and of
>> course Lisp (CL and ELisp). Should I add those?
SM> Feel free. I only added the ones I actually worked on. BTW, the
SM> octave.m testcase is too long for that kind of test (although the length
SM> was instrumental in fixing some performance bugs).
See the attached patch to make the indentation testing use ERT and
operate on any files with a "." in the name except test-indent.el.
The test fails on modula2.mod and I'm not sure why. I am setting
`enable-local-variables'. Is it because I'm going line by line? Or
something with the line boundaries?
Should the test stop when any file fails or keep going?
Thanks
Ted
=== modified file 'test/indent/Makefile'
--- test/indent/Makefile 2010-08-30 20:34:52 +0000
+++ test/indent/Makefile 2011-06-01 20:48:21 +0000
@@ -13,3 +13,6 @@
--eval '(indent-region (point-min) (point-max) nil)' \
--eval '(write-region (point-min) (point-max) "$<.new")'
diff -u -B $< $<.new
+
+test-indent:
+ $(EMACS) --batch -l ert -l test-indent.el -f
ert-run-tests-batch-and-exit
=== added file 'test/indent/test-indent.el'
--- test/indent/test-indent.el 1970-01-01 00:00:00 +0000
+++ test/indent/test-indent.el 2011-06-01 21:28:07 +0000
@@ -0,0 +1,57 @@
+;;; test-indent.el --- run indentation tests
+
+;; Copyright (C) 2011 Free Software Foundation, Inc.
+
+;; Author: Ted Zlatanov <address@hidden>
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; The purpose of this module is to verify that all the files in te
+;; current directory are indented correctly.
+
+;;; Code:
+
+(eval-when-compile
+ (require 'ert)
+ (require 'cl))
+
+(ert-deftest test-indent-all ()
+ (let ((enable-local-variables :all)
+ lnum)
+ (loop for f in (delete "test-indent.el"
+ (directory-files "." nil "^[^.]+\\."))
+ do (with-temp-buffer
+ (message "Testing indentation of %s" f)
+ (insert-file-contents f)
+ (goto-char (point-min))
+ (setq lnum 0)
+ (while (not (eobp))
+ (incf lnum)
+ (let* ((a (line-beginning-position))
+ (b (line-end-position))
+ (line (buffer-substring a b)))
+ (message "Testing indentation of %s:%05d: %s" f lnum line)
+ (unless (string-match "KNOWN INDENT BUG" line)
+ (indent-region a b nil)
+ (should (equal line (buffer-substring
+ (line-beginning-position)
+ (line-end-position)))))
+ (forward-line)))))))
+
+(provide 'test-indent)
+;;; test-indent.el ends here
- Re: ERT indentation testing,
Ted Zlatanov <=
- Re: ERT indentation testing, Ted Zlatanov, 2011/06/02
- Re: ERT indentation testing, Stefan Monnier, 2011/06/02
- Re: ERT indentation testing, Ted Zlatanov, 2011/06/03
- Re: ERT indentation testing, martin rudalics, 2011/06/03
- extra-interactive functions (was: ERT indentation testing), Ted Zlatanov, 2011/06/03
- Re: extra-interactive functions, martin rudalics, 2011/06/03
- Re: extra-interactive functions, Ted Zlatanov, 2011/06/03
- Re: extra-interactive functions, martin rudalics, 2011/06/03
- Re: extra-interactive functions, Ted Zlatanov, 2011/06/03
- Re: extra-interactive functions, martin rudalics, 2011/06/03