emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: 5x5 again


From: Vincent Belaïche
Subject: RE: 5x5 again
Date: Wed, 25 May 2011 08:13:51 +0200

Ooops...

I noticed another thing: in the docstring of 5x5, there the keymap is listed, but I omitted to add that line:

Solve with Calc           \\[5x5-solve-suggest]

I can prepare one more patch & Changelog --- with well capitalized sentences --- if you like. If I do this, I would also add a function to browse through the other solutions found by the solver --- only the one with least Hamming weight being shown.

   Vincent.

> From: address@hidden
> To: address@hidden
> CC: address@hidden; address@hidden
> Subject: Re: 5x5 again
> Date: Tue, 24 May 2011 15:23:59 -0300
>
> > Here follows the Changelog and the patch. Sorry for the extra
> > disturbance.
>
> Installed, with the following nitpicks:
>
> > * play/5x5.el (5x5-new-game, 5x5-randomize): reset
> > 5x5-solver-output to nil when a new grid is cast.
>
> "reset" needs to be capitalized.
>
> > (5x5-log-init, 5x5-log): use defsubst instead of defmacro to shunt
>
> "use" needs to be capitalized.
>
> > these debugging traces, as defmacro breaks the compiled code. Note
>
> Two spaces after ".".
>
> > these logging facilities were not cleaned out as the aritmetic
> > solver is not yet complete --- it works only for grid size = 5. So
> > they may be useful again to design a more generic solution.
>
> I moved this into the code, where it belongs.
>
>
> Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]