Re: Reviewing changes

[Karl Fogel]

Eli Zaretskii <address@hidden> writes:
>> From: Karl Fogel <address@hidden>
>> Cc: address@hidden,  address@hidden
>> Date: Wed, 19 Nov 2008 17:06:07 -0500
>> 
>> We don't need to have a fully-specified, formal review system to benefit
>> from more frequent informal reviews.  Many projects get by on just
>> having the diff+log appear in the same email -- then the review "system"
>> is simply people reading their email.  It works quite well.
>
> If there's no agreement to have a review process, I can simply ignore
> your review.

Sure.  You could ignore my comments on any change you make, right now.
I'm just talking about making it easier for people to review and comment
on others' changes, so that we catch more bugs.

We do have a review process currently: it consists of watching two
separate mailing lists and re-stitching together various messages in
order to comprehend (and maybe respond to) a logical change.  But every
part of that before the word "comprehend" is unnecessary work for our
developers.  The more of that stuff we can automate away, the more
inclined people will be to look at changes.

This is about making it easier to add information to the system.  What
people do with the information is up to them.  But generally, people
seem to not ignore such comments now, so we have no reason to worry that
they would suddenly start ignoring them.

[Maybe I should have read the rest of the thread before responding :-),
as it seems others agree that making review easier would be a good
thing.  I'll follow up to Stephen Turnbull's message now.]

-Karl