emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use "do...while (0)", not "if (1)..else" in macro definition


From: Jan Djärv
Subject: Re: [PATCH] Use "do...while (0)", not "if (1)..else" in macro definitions.
Date: Tue, 05 Feb 2008 08:09:30 +0100
User-agent: Thunderbird 2.0.0.9 (X11/20071031)



Jim Meyering skrev:
2008-01-28  Jim Meyering  <address@hidden>

        Use "do...while (0)", not "if (1)..else" in macro definitions.
        The latter provokes a warning from gcc about the empty else, when
        followed by ";".  Also, without that trailing semicolon, it would
        silently swallow up any following statement.
        * syntax.h (SETUP_SYNTAX_TABLE):
        (SETUP_SYNTAX_TABLE_FOR_OBJECT): Likewise.
        * buffer.h (DECODE_POSITION): Likewise.
        * charset.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
        (FETCH_STRING_CHAR_ADVANCE_NO_CHECK): Likewise.
        (FETCH_CHAR_ADVANCE): Likewise.

Ping?

http://thread.gmane.org/gmane.emacs.devel/87706


I'll put this in when the merge activities settle down a bit.

        Jan D.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]