Re: weird desktop.el change

[Richard Stallman]

    > 2007-04-13  Markus Triska  <address@hidden>

    >   * emacs-lisp/byte-opt.el (byte-optimize-form-code-walker): rewrite
    >   `mapcar' to `mapc' when called for effect

    Please, let's not add this before the release.

I agree.

    PS: I'm not even sure it's a good optimization: in 99% of the cases it would
    be better to educate the programmer about mapc by emitting a warning, and in
    99% of those cases, it'd be even better to replace the mapc(ar) by
    a dolist loop.

Markus says his code does issue a warning.  However, I think it would
be better to implement this warning in the code generation stage so as
to give the warning the correct line number.

I think that would make the optimization unnecessary.