Re: Patch: Show signature state in encrypted messages using pgg

[Sascha Wilde]

Daiki Ueno <address@hidden> wrote:

>>>>>> In <address@hidden> 
>>>>>>  Sascha Wilde <address@hidden> wrote:
>> Daiki Ueno <address@hidden> wrote:

>> > Is there still any chance for such a feature enhancement to get into the
>> > release?  Anyway,
>
>> No, I don't think so, but I think that:
>> 1. There is a chance to get it into gnus CVS
>
> If so, you should make a patch to the Gnus trunk, I think.

This might me right.  I tend to make my changes in the sources of CVS
Emacs as that's what I'm using as my productive working environment.

I'll port my changes to CVS gnus if that helps.

> You are appearantly missing that Gnus set
> application/x-gnus-pgp-encrypted for traditional inline PGP messages.  I
> agree these messages are "quite non standard".

Yes, I missed that indeed.  Thanks for pointing it out to me, now I
know how to test it and indeed with my proposed change to
mm-uu-pgp-encrypted-extract-1 it works well.

>> Anyway how about something along the lines of 
>
>> ;;; untested:
>> (progn
>>   (mml2015-clean-buffer)
>>   (funcall (mml2015-clear-decrypt-function))
>>   (eq t
>>       (compare-strings "OK" nil nil
>>                     (mm-handle-multipart-ctl-parameter mm-security-handle
>>                                                        'gnus-info)
>>                     nil 2)))
>
>> this should fix it.
>
> At least XEmacs 21.4 does not have compare-strings.

Sure?

(version)
"GNU Emacs 21.4.1 (i386-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2005-03-17 on trouble, modified by Debian"
(compare-strings "OK" nil nil "OK, Signer" nil 2)
t

On the other hand: is backwards compatibility still an issue for gnus
development anyway, with Emacs 22 being released soon?

> BTW, why do you tend to spread your kludge here and there?  Why not
> use some other parameters such as 'gnus-details instead?

'gnus-details contains the important information already, but

1. The information on the signature (if any) is buried between many
   lines of verbose information.

2. The information in 'gnus-details is not visible by default, the
   user has to show it by pressing the [[PGP Encrypted Part:OK]]
   button.

The reason for my patch is, that I think, that the Information if and
by whom an encrypted message is signed is _very_ important, and should
be always visible.

Btw: mml2015-mailcrypt-decrypt does return the same as
mml2015-pgg-decrypt does with my patch (and I used it as an example
for the exact format of the returned string).

cheers
sascha
-- 
Sascha Wilde
"Gimme about 10 seconds to think for a minute..."