emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Pretest


From: Richard Stallman
Subject: Re: Pretest
Date: Tue, 31 Oct 2006 21:12:50 -0500

       > -X11_LDFLAGS = LD_SWITCH_X_SITE LD_SWITCH_X_DEFAULT
       > +X11_LDFLAGS = C_SWITCH_SYSTEM LD_SWITCH_X_SITE LD_SWITCH_X_DEFAULT

       I think it should be LD_SWITCH_SYSTEM, not C_SWITCH_SYSTEM.  Does
       using LD_SWITCH_SYSTEM instead work?

    No.  LD_SWITCH_SYSTEM won't work because it isn't set on OpenBSD.

Neither one belongs in X11_LDFLAGS.  X11_LDFLAGS is supposed to be the
_additional_ flags needed before the X libraries.  Changing it on an
ad hoc basis just because it makes one bug disappear is the wrong way to
maintain Makefile.in.

The right thing to do is to change LD_SWITCH_X_DEFAULT.
(Changing LD_SWITCH_SYSTEM might also be an ok approach.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]