emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Saving minibuffer history


From: Hrvoje Niksic
Subject: Re: Saving minibuffer history
Date: Tue, 25 Oct 2005 11:20:15 +0200
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux)

Stefan Monnier <address@hidden> writes:

> Almost.  There were a few comments missing, and things like that.

You never informed me about those changes so I missed them.  I did
notice the changes in the patch you sent me.  Please remember that
this package is normally also maintained for XEmacs, and as an
external package (although it probably doesn't have many external
users).

I also don't understand why you removed the "*" markers from the
beginning of docstrings.  Those variables *are* intended to be "set
and modified by users".

> E.g. please preserve the arch-tag.

I don't know what it does and I don't use arch.  Is it always the
same?  What purpose does it serve?

> As mentioned earlier, your code truncates non-history variables as
> well.  But now that you use it to save the list of variables as
> well, it means that if the number of history variables you have is
> larger than savehist-length, than you will lose some of your history
> as well.

Fixed now, thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]