[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Diff mode faces
From: |
Eli Zaretskii |
Subject: |
Re: Diff mode faces |
Date: |
Sat, 16 Jul 2005 14:17:02 +0300 |
> From: Juri Linkov <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Tue, 12 Jul 2005 09:51:05 +0300
>
> Here is a new patch:
I tried that on a tty. I'm mildly worried about the visibility of
green on (the default) white background: is it possible that it will
stand out too much? If it's possible, then this change is not good,
since `shadow' should not stand out.
But in my case, it didn't stand out, so I have no objections for this
change.
> Index: lisp/faces.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
> retrieving revision 1.329
> diff -u -r1.329 faces.el
> --- lisp/faces.el 4 Jul 2005 23:08:54 -0000 1.329
> +++ lisp/faces.el 12 Jul 2005 06:33:20 -0000
> @@ -2149,8 +2148,10 @@
> :version "22.1")
>
> (defface shadow
> - '((((background dark)) :foreground "grey70")
> - (((background light)) :foreground "grey50"))
> + '((((min-colors 88) (background light)) :foreground "grey50")
> + (((min-colors 88) (background dark)) :foreground "grey70")
> + (((background light)) :foreground "green")
> + (((background dark)) :foreground "yellow"))
> "Basic face for shadowed text."
> :group 'basic-faces
> :version "22.1")
>
> Index: lisp/diff-mode.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/diff-mode.el,v
> retrieving revision 1.78
> diff -u -r1.78 diff-mode.el
> --- lisp/diff-mode.el 4 Jul 2005 23:08:52 -0000 1.78
> +++ lisp/diff-mode.el 12 Jul 2005 06:35:03 -0000
> @@ -259,7 +280,7 @@
> (defvar diff-function-face 'diff-function)
>
> (defface diff-context
> - '((t :inherit shadow))
> + '((((min-colors 88)) :inherit shadow))
> "`diff-mode' face used to highlight context and other side-information."
> :group 'diff-mode)
> ;; backward-compatibility alias
- Re: Diff mode faces, (continued)
- Re: Diff mode faces, Juri Linkov, 2005/07/06
- Re: Diff mode faces, Eli Zaretskii, 2005/07/06
- Re: Diff mode faces, Juri Linkov, 2005/07/09
- Re: Diff mode faces, Eli Zaretskii, 2005/07/09
- Re: Diff mode faces, Juri Linkov, 2005/07/11
- Re: Diff mode faces, Stefan Monnier, 2005/07/11
- Re: Diff mode faces, Eli Zaretskii, 2005/07/11
- Re: Diff mode faces, Stefan Monnier, 2005/07/11
- Re: Diff mode faces, Eli Zaretskii, 2005/07/11
- Re: Diff mode faces, Juri Linkov, 2005/07/12
- Re: Diff mode faces,
Eli Zaretskii <=
- Re: Diff mode faces, Miles Bader, 2005/07/07
- Re: Diff mode faces, Juri Linkov, 2005/07/07