Re: [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el

[Juri Linkov]

"Eli Zaretskii" <address@hidden> writes:
> No, the minibuffer-prompt face is one of the few cases where the
> literal `pc' is deliberate.  It so happens that many users of the
> MS-DOS port use blue as their default foreground color.

Aha.  But then a condition like ((class color) (background "blue"))
would be mode appropriate.  Not for this release, though.

>> The idea was to make escape-glyph to look like comments
>
> I'm not sure that was a good idea, since comments normally have a face
> that makes them stand out.  I thought that several people complained
> about ^L being too glaring.

For light background color "dark red" does not stand out.  The color
for dark background for (min-colors 88) perhaps does not stand out too
(if bright colors which don't stand out are possible at all).

But there is no color for 8-color terminals which does not stand out.
Thus, there is red for (min-colors 8).  Another choice would be
not to highlight escape sequences 8-color terminals.

>> +(defface escape-glyph
>> +  '((((class color) (min-colors 88) (background light))
>> +     :foreground "dark red")
>> +    (((class color) (min-colors 88) (background dark))
>> +     :foreground "tan1")
>> +    (((class color) (min-colors 8))
>> +     :foreground "red"))
>> +  "Face for characters displayed as ^-sequences or \\-sequences."
>>    :group 'basic-faces)

-- 
Juri Linkov
http://www.jurta.org/emacs/