Re: [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el

[Juri Linkov]

"Eli Zaretskii" <address@hidden> writes:
> Please don't use `(type pc)' in face definitions; we now have the
> min-colors feature to express the same color selection in a more
> device-independent way (e.g., it will also be right for a 16-color
> xterm).

OK.  But then `minibuffer-prompt' face whose definition was copied to
`escape-glyph' should be fixed too:

diff -u -w -b -r1.297 faces.el
-(defface minibuffer-prompt '((((background dark)) :foreground "cyan")
-                            (((type pc)) :foreground "magenta")
-                            (t :foreground "dark blue"))
+(defface minibuffer-prompt
+  '((((class color) (min-colors 88) (background light))
+     :foreground "dark blue")
+    (((class color) (min-colors 8) (background light))
+     :foreground "blue")
+    (((class color) (min-colors 8) (background dark))
+     :foreground "cyan"))
   "Face for minibuffer prompts."
   :version "21.4"
   :group 'basic-faces)

There will be no default, because it's not necessary to highlight
minibuffer prompts (in inverse-video or with other non-color
properties) on non-color displays.  And cyan for dark backgrounds
exists even on 8-color terminals.
 
> Also, I think "magenta" is a bad color choice for 16-color terminals,
> as its definition in tty-colors.el will produce a color that is very
> different from "burlywood2".  How about "brown" or "yellow" instead?
>
> The 8-color terminals will also need a separate definition (yellow?):
> "burlywood2" translates there to "green", believe it or not.

The idea was to make escape-glyph to look like comments because most
frequent control character ^L in the source files will look like
comments (it is also similar to comments syntaxically, since it is
skipped by the reader together with comments).  So a better choice
for the color of escape-glyph on 8-color terminals would be red,
regardless of background mode:

diff -u -w -b -r1.297 faces.el
-(defface escape-glyph '((((background dark)) :foreground "cyan")
-                       (((type pc)) :foreground "magenta")
-                       (t :foreground "blue"))
-  "Face for characters displayed as ^-sequences or \-sequences."
+(defface escape-glyph
+  '((((class color) (min-colors 88) (background light))
+     :foreground "dark red")
+    (((class color) (min-colors 88) (background dark))
+     :foreground "tan1")
+    (((class color) (min-colors 8))
+     :foreground "red"))
+  "Face for characters displayed as ^-sequences or \\-sequences."
   :group 'basic-faces)

-- 
Juri Linkov
http://www.jurta.org/emacs/