[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Last change to process.c breaks fetching pop3 mail (gnus/pop3.el)
From: |
Kim F. Storm |
Subject: |
Re: Last change to process.c breaks fetching pop3 mail (gnus/pop3.el) |
Date: |
31 May 2004 23:06:43 +0200 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
Noah Friedman <address@hidden> writes:
> I left a comment in the source that explained why I removed the call. In
> summary, calling remove_process there does 2 things wrong:
>
> (1) network process objects are removed from Vprocess_alist even if
> delete-exited-processes is nil
The doc string for delete-process says:
Delete PROCESS: kill it and forget about it immediately.
To me 'immediately' means that the value of delete-exited-processes
does not apply here. So I don't agree this is an error.
> (2) network processes never have their sentinel called a final time
Right, that's a real bug.
The following patch should fix that (after undoing your change).
*** process.c 24 May 2004 09:49:49 +0200 1.429
--- process.c 31 May 2004 22:28:55 +0200
***************
*** 764,769 ****
--- 764,770 ----
{
XPROCESS (process)->status = Fcons (Qexit, Fcons (make_number (0),
Qnil));
XSETINT (XPROCESS (process)->tick, ++process_tick);
+ status_notify ();
}
else if (XINT (XPROCESS (process)->infd) >= 0)
{
Unless you see problems with this, I'll install the patch tomorrow.
--
Kim F. Storm <address@hidden> http://www.cua.dk