Exit status inserted in shell command output buffer

[Kim F. Storm]

I don't like the new `functionality' which adds the line
"...Shell command failed with code X"
to the *Shell Command Output* buffer when a command returns
a non-zero exit status.

I think these are the relevant changes:

2002-02-20  Richard M. Stallman  <address@hidden>

        * simple.el (shell-command-on-region): Display the exit status
        when a command fails.

2001-12-13  Richard M. Stallman  <address@hidden>

        * simple.el
        (shell-command-on-region): If there is output an an error,
        add "...Shell command failed" to the output.


In my mind, if a command produces output, emacs shouldn't modify
(i.e. add to) the output from the command!

What do others think?

Example:

Index: shell.el
===================================================================
RCS file: /cvs/emacs/lisp/shell.el,v
retrieving revision 1.106
retrieving revision 1.107
diff -r1.106 -r1.107
318c318,319
<        (copy-keymap (lookup-key comint-mode-map [menu-bar completion])))
---
>        (cons "Complete" 
>              (copy-keymap (lookup-key comint-mode-map [menu-bar 
> completion]))))
..Shell command failed with code 1


So `cvs diff' exited with code 1 because the two revisions differ.
But in my mind, the command didn't fail -- it worked just fine.
The first time I saw this, I thought that there was actually some
error causing the diff output to have been truncated....


++kfs